You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 9, 2025. It is now read-only.
There are some issues around logging that can be improved,
Warning seems to be "too aggressive" in the Sphinx content. People uses a lot -W when building their docs on CI systems. This means that their builds fails because hoverxref logs some warnings.
Warning on hoverxref not fully configurated, may be better as INFO as well. Otherwise, people need to force the definition of it in their conf.py --when the extension only works on Read the Docs and this is automatically configured.
A lot of log.info is thrown in the output mentioning the data that was injected. This is useful when debugging only, so it may be good to change to that level.
Usage of default role it's better candidate for an info (at this line). We already have a config that sets the default role.
I'm not super happy introducing these warning changes in the latest release because it broke some users builds. However, they seem to be good warnings by default, so the first time you install the extension you are able to configure it completely.
There are some issues around logging that can be improved,
-W
when building their docs on CI systems. This means that their builds fails because hoverxref logs some warnings.conf.py
--when the extension only works on Read the Docs and this is automatically configured.log.info
is thrown in the output mentioning the data that was injected. This is useful when debugging only, so it may be good to change to that level.I'm not super happy introducing these warning changes in the latest release because it broke some users builds. However, they seem to be good warnings by default, so the first time you install the extension you are able to configure it completely.
References: scrapy/scrapy#4480
The text was updated successfully, but these errors were encountered: