Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

DeprecationWarning with Sphinx v8.0.2 #312

Closed
Zac-HD opened this issue Oct 8, 2024 · 7 comments · Fixed by #313
Closed

DeprecationWarning with Sphinx v8.0.2 #312

Zac-HD opened this issue Oct 8, 2024 · 7 comments · Fixed by #313

Comments

@Zac-HD
Copy link
Contributor

Zac-HD commented Oct 8, 2024

.../python3.10/site-packages/hoverxref/extension.py:312: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  default, rebuild, types = app.config.values.get('hoverxref_tooltip_api_host')
.../python3.10/site-packages/hoverxref/extension.py:280: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  default, rebuild, types = app.config.values.get('hoverxref_modal_class')
.../python3.10/site-packages/hoverxref/extension.py:67: RemovedInSphinx90Warning: The '_Opt' object tuple interface is deprecated, use attribute access instead for 'default', 'rebuild', and 'valid_types'.
  context[attr] = app.config.values[attr][0]

found via this CI run on HypothesisWorks/hypothesis#4129, where we continue to be very happy that hoverxref exists 💖

@humitos
Copy link
Member

humitos commented Oct 8, 2024

Hi 👋🏼 . Would you like to provide a PR? It shouldn't be too hard.

We did a similar work in readthedocs/sphinx-notfound-page#236 for another extension we maintain. Note that we have to check for Sphinx 7.3, tho, since we fixed that in a later PR at readthedocs/sphinx-notfound-page#241

@Zac-HD
Copy link
Contributor Author

Zac-HD commented Nov 13, 2024

Hi Manuel, I've opened #313 to fix this issue 🙂

Thanks for all your work on readthedocs!

@jakkdl
Copy link

jakkdl commented Apr 3, 2025

Would it be possible to push a small patch release with this fix? :)

@humitos
Copy link
Member

humitos commented Apr 3, 2025

@jakkdl this extension is deprecated now since the feature was introduced in Read the Docs application itself. It's now called links preview: https://docs.readthedocs.com/platform/stable/link-previews.html

@edgarrmondragon
Copy link

@jakkdl this extension is deprecated now since the feature was introduced in Read the Docs application itself. It's now called links preview: https://docs.readthedocs.com/platform/stable/link-previews.html

Should a warning be added to the readme in this repo, as well as a link to those docs and/or https://github.com/readthedocs/addons?

@humitos
Copy link
Member

humitos commented Apr 7, 2025

Should a warning be added to the readme in this repo, as well as a link to those docs and/or readthedocs/addons?

Yes. I just haven't had the time to do it. Would you want to open a PR with this?

@agriyakhetarpal
Copy link
Contributor

Should a warning be added to the readme in this repo, as well as a link to those docs and/or readthedocs/addons?

Yes. I just haven't had the time to do it. Would you want to open a PR with this?

I've put together a PR to mark the extension as deprecated: #337

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants