Skip to content

Django3: delete old JSONField and use the new ones #8869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 14, 2022
Merged

Django3: delete old JSONField and use the new ones #8869

merged 6 commits into from
Feb 14, 2022

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 31, 2022 •
edited
Loading 

In [3]: Build.objects.filter(_config__build__image='readthedocs/build:latest')
Out[3]: <BuildQuerySet [<Build: Build qtile for admin (2)>, <Build: Build qtile for admin (1)>]>

Requires: #8868

@humitos
Django3: remove old non-JSONFields and kept the new ones only
ff6184b 
```
In [3]: Build.objects.filter(_config__build__image='readthedocs/build:latest')
Out[3]: <BuildQuerySet [<Build: Build qtile for admin (2)>, <Build: Build qtile for admin (1)>]>
```
@humitos humitos requested a review from a team as a code owner January 31, 2022 12:19
@humitos humitos changed the title Django3: add new django.db.models.JSONField Django3: delete old JSONField and use the new ones Jan 31, 2022
@humitos humitos mentioned this pull request Feb 1, 2022
Merged
@ericholscher ericholscher added the Status: blocked Issue is blocked on another issue label Feb 2, 2022
ericholscher
ericholscher approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's safe to run these back to back, correct? So they can both go out in the same deploy?

requirements/pip.txt

# This module is only used on migrations. We are now using Django's official
# JSONField. We should probably squash these migrations and remove this
# dependency as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@humitos humitos mentioned this pull request Feb 3, 2022
Merged
@humitos
Copy link
Member Author

humitos commented Feb 8, 2022

I'm moving this out to next's week deploy.

@humitos humitos removed the Status: blocked Issue is blocked on another issue label Feb 14, 2022
Base automatically changed from humitos/new-json-fields to master February 14, 2022 19:21
@humitos humitos enabled auto-merge February 14, 2022 19:46
@humitos humitos merged commit b749a2a into master Feb 14, 2022
@humitos humitos deleted the humitos/remove-old-jsonfields branch February 14, 2022 23:21
@humitos humitos mentioned this pull request Feb 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @ericholscher