From ba5f99c8974ae0693d8e9edfad26de6895629ee0 Mon Sep 17 00:00:00 2001 From: Manuel Kaufmann Date: Mon, 2 Nov 2020 15:38:18 +0100 Subject: [PATCH] Check only override settings Since we are using this tests in -corporate as well, we need to check only for settings wee are override in the test to avoid passing in .org and failing in .com --- readthedocs/rtd_tests/tests/test_notifications.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/readthedocs/rtd_tests/tests/test_notifications.py b/readthedocs/rtd_tests/tests/test_notifications.py index 5a3d00f60ed..87039631607 100644 --- a/readthedocs/rtd_tests/tests/test_notifications.py +++ b/readthedocs/rtd_tests/tests/test_notifications.py @@ -32,6 +32,7 @@ 'readthedocs.notifications.backends.SiteBackend', ], PRODUCTION_DOMAIN='readthedocs.org', + SUPPORT_EMAIL='support@readthedocs.org', ) @mock.patch('readthedocs.notifications.notification.render_to_string') @mock.patch.object(Notification, 'send') @@ -69,16 +70,16 @@ class TestNotification(Notification): 'request': req, # readthedocs_processor context - 'DASHBOARD_ANALYTICS_CODE': None, - 'DO_NOT_TRACK_ENABLED': False, - 'GLOBAL_ANALYTICS_CODE': None, + 'DASHBOARD_ANALYTICS_CODE': mock.ANY, + 'DO_NOT_TRACK_ENABLED': mock.ANY, + 'GLOBAL_ANALYTICS_CODE': mock.ANY, 'PRODUCTION_DOMAIN': 'readthedocs.org', - 'PUBLIC_DOMAIN': None, + 'PUBLIC_DOMAIN': mock.ANY, 'SITE_ROOT': mock.ANY, - 'SUPPORT_EMAIL': None, + 'SUPPORT_EMAIL': 'support@readthedocs.org', 'TEMPLATE_ROOT': mock.ANY, - 'USE_PROMOS': False, - 'USE_SUBDOMAIN': False, + 'USE_PROMOS': mock.ANY, + 'USE_SUBDOMAIN': mock.ANY, }, )