From 06fc7ebd3a6ed70235a562abba97933ee51e562e Mon Sep 17 00:00:00 2001 From: David Fischer Date: Sat, 18 Aug 2018 14:13:54 -0700 Subject: [PATCH] Handle ports in X Forwarded For --- readthedocs/analytics/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readthedocs/analytics/utils.py b/readthedocs/analytics/utils.py index e0479d951d6..44eef551125 100644 --- a/readthedocs/analytics/utils.py +++ b/readthedocs/analytics/utils.py @@ -26,7 +26,7 @@ def get_client_ip(request): # Get the original IP address (eg. "X-Forwarded-For: client, proxy1, proxy2") x_forwarded_for = request.META.get('HTTP_X_FORWARDED_FOR', '').split(',')[0] if x_forwarded_for: - ip_address = x_forwarded_for + ip_address = x_forwarded_for.rsplit(':')[0] return ip_address