From f4adafbdb1871089b52cb8977f7bdd5ade17f459 Mon Sep 17 00:00:00 2001 From: Santos Gallegos Date: Wed, 19 Mar 2025 17:28:24 -0500 Subject: [PATCH 1/2] Small improvements on PR previews handling --- readthedocs/core/views/hooks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readthedocs/core/views/hooks.py b/readthedocs/core/views/hooks.py index f845711ca73..dd7830a79b8 100644 --- a/readthedocs/core/views/hooks.py +++ b/readthedocs/core/views/hooks.py @@ -150,6 +150,7 @@ def get_or_create_external_version(project, version_data): external_version.identifier = version_data.commit # If the PR was previously closed it was marked as closed external_version.state = EXTERNAL_VERSION_STATE_OPEN + external_version.active = True external_version.save() log.info( "External version updated.", @@ -175,7 +176,6 @@ def close_external_version(project, version_data): project.versions(manager=EXTERNAL) .filter( verbose_name=version_data.id, - identifier=version_data.commit, ) .first() ) From 0bb988829d2eb9432e5e24c636d9de9001a09322 Mon Sep 17 00:00:00 2001 From: Santos Gallegos Date: Wed, 19 Mar 2025 17:30:33 -0500 Subject: [PATCH 2/2] Format --- readthedocs/core/views/hooks.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/readthedocs/core/views/hooks.py b/readthedocs/core/views/hooks.py index dd7830a79b8..4000b2b3f45 100644 --- a/readthedocs/core/views/hooks.py +++ b/readthedocs/core/views/hooks.py @@ -173,11 +173,7 @@ def close_external_version(project, version_data): :rtype: str """ external_version = ( - project.versions(manager=EXTERNAL) - .filter( - verbose_name=version_data.id, - ) - .first() + project.versions(manager=EXTERNAL).filter(verbose_name=version_data.id).first() ) if external_version: