From 3225c38998f0ef2f5831aa0604ab6cd663a403e1 Mon Sep 17 00:00:00 2001 From: Manuel Kaufmann Date: Tue, 8 Aug 2023 14:43:29 +0200 Subject: [PATCH] Profile: redirect to `/accounts/edit/` view on successful edit Closes #10404 --- readthedocs/profiles/views.py | 3 +-- readthedocs/rtd_tests/tests/test_profile_views.py | 13 +++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/readthedocs/profiles/views.py b/readthedocs/profiles/views.py index 97607e0eda5..00f72266458 100644 --- a/readthedocs/profiles/views.py +++ b/readthedocs/profiles/views.py @@ -61,8 +61,7 @@ def get_object(self): def get_success_url(self): return reverse( - 'profiles_profile_detail', - kwargs={'username': self.request.user.username}, + "profiles_profile_edit", ) diff --git a/readthedocs/rtd_tests/tests/test_profile_views.py b/readthedocs/rtd_tests/tests/test_profile_views.py index 42298cde234..a8bf31d439b 100644 --- a/readthedocs/rtd_tests/tests/test_profile_views.py +++ b/readthedocs/rtd_tests/tests/test_profile_views.py @@ -36,6 +36,7 @@ def test_edit_profile(self): }, ) self.assertTrue(resp.status_code, 200) + self.assertEqual(resp["Location"], "/accounts/edit/") self.user.refresh_from_db() self.user.profile.refresh_from_db() @@ -195,32 +196,32 @@ def test_list_security_logs(self): resp = self.client.get(reverse('profiles_security_log')) self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data['object_list'] - self.assertQuerysetEqual(auditlogs, queryset) + self.assertQuerySetEqual(auditlogs, queryset) # Show logs filtered by project. resp = self.client.get(reverse('profiles_security_log') + '?project=project') self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data["object_list"] - self.assertQuerysetEqual(auditlogs, queryset.filter(log_project_slug="project")) + self.assertQuerySetEqual(auditlogs, queryset.filter(log_project_slug="project")) # Show logs filtered by IP. ip = "10.10.10.2" resp = self.client.get(reverse("profiles_security_log") + f"?ip={ip}") self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data['object_list'] - self.assertQuerysetEqual(auditlogs, queryset.filter(ip=ip)) + self.assertQuerySetEqual(auditlogs, queryset.filter(ip=ip)) # Show logs filtered by action. resp = self.client.get(reverse('profiles_security_log') + '?action=authentication') self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data['object_list'] - self.assertQuerysetEqual(auditlogs, queryset.filter(action=AuditLog.AUTHN)) + self.assertQuerySetEqual(auditlogs, queryset.filter(action=AuditLog.AUTHN)) # Show logs filtered by action. resp = self.client.get(reverse('profiles_security_log') + '?action=authentication-failure') self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data["object_list"] - self.assertQuerysetEqual( + self.assertQuerySetEqual( auditlogs, queryset.filter(action=AuditLog.AUTHN_FAILURE) ) @@ -235,7 +236,7 @@ def test_list_security_logs(self): resp = self.client.get(reverse('profiles_security_log') + '?action=invalid') self.assertEqual(resp.status_code, 200) auditlogs = resp.context_data['object_list'] - self.assertQuerysetEqual(auditlogs, queryset) + self.assertQuerySetEqual(auditlogs, queryset) @override_settings(