Skip to content

Mention/add npm run vendor in our frontend dev steps #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Jan 5, 2023 · 2 comments
Closed

Mention/add npm run vendor in our frontend dev steps #9867

stsewd opened this issue Jan 5, 2023 · 2 comments
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required

Comments

@stsewd
Copy link
Member

stsewd commented Jan 5, 2023

We don't update our vendored packages that often, but when needed, I had no idea how to update them, we lost that step when migrating the process to docker.

See

@stsewd stsewd added the Accepted Accepted issue on our roadmap label Jan 5, 2023
@humitos humitos added the Needed: documentation Documentation is required label Jan 5, 2023
@humitos
Copy link
Member

humitos commented Sep 15, 2023

This probably won't required anymore since we are migrating all the frontend things to addons and ex-theme. I don't we will need to rebuild the frontend things from this repository anymore.

Also, I think the current pattern is just running inv docker.buildassets

@humitos humitos closed this as completed Sep 15, 2023
@stsewd
Copy link
Member Author

stsewd commented Sep 18, 2023

Also, I think the current pattern is just running inv docker.buildassets

That doesn't run npm run vendor

https://github.com/readthedocs/common/blob/e6da5905c17254b5e8d78adc20e77a88f51f41f1/dockerfiles/tasks.py#L165-L169

I haven't been following the frontend changes, so up to you if you thinks this is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: documentation Documentation is required
Projects
None yet
Development

No branches or pull requests

2 participants