You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For all generated pages, the RTD injected versions may have an associated source view/edit links to the respective source repository (e.g. view/edit links to GitHub):
These links should always be pointing to the respective source files for the rendered document.
Actual Result
If pages are published using the html_additional_pages option, these links may not be generated correctly. For example, with a configuration such as:
And a project using, for example, GitHub should have the index page resolve to a path such as:
<project>/blob/main/doc/index.html
However, the existing link generates a link to:
<project>/blob/main/doc/index.rst
Not that experienced with RTD's implementation, but this may be as simple as:
Adjusting the configuration scrape logic to capture the html_additional_pages value.
Adjusting BaseFooterHTML._get_context so that when page_slug maps to an entry in html_additional_pages, page_slug is swapped to the value in the dictionary and source_suffix is cleared.
The text was updated successfully, but these errors were encountered:
humitos
changed the title
support repository links when using html_additional_pages
Hosting: support repository links when using html_additional_pagesJan 31, 2023
I'm going to close this issue since we won't integrate the flyout with specific Sphinx things. We are trying to make all our new features to be agnostic of the doctool used.
Details
Expected Result
For all generated pages, the RTD injected versions may have an associated source view/edit links to the respective source repository (e.g. view/edit links to GitHub):
These links should always be pointing to the respective source files for the rendered document.
Actual Result
If pages are published using the
html_additional_pages
option, these links may not be generated correctly. For example, with a configuration such as:And a project using, for example, GitHub should have the index page resolve to a path such as:
However, the existing link generates a link to:
Not that experienced with RTD's implementation, but this may be as simple as:
html_additional_pages
value.BaseFooterHTML._get_context
so that whenpage_slug
maps to an entry inhtml_additional_pages
,page_slug
is swapped to the value in the dictionary andsource_suffix
is cleared.The text was updated successfully, but these errors were encountered: