Build: append Conda requirements for non Conda builds

[sentry-io]

How did we ended up into _append_conda_requirements if the build is not a Conda build? Is this a config file validation issue? Is the workflow broken for some cases?

In [1]: b = Build.objects.get(task_id='82b5dcc4-58a5-4997-8fc4-d8eafcc89df9')

In [2]: b.get_absolute_url()
Out[2]: '/projects/gdptools/builds/18010191/'

In [3]:

• Build URL: https://readthedocs.org/projects/gdptools/builds/18010191/

Sentry Issue: READTHEDOCS-ORG-PBW

AttributeError: 'NoneType' object has no attribute 'environment'
(3 additional frame(s) were not displayed)
...
  File "readthedocs/projects/tasks/builds.py", line 691, in execute
    self.data.build_director.setup_environment()
  File "readthedocs/doc_builder/director.py", line 161, in setup_environment
    self.create_environment()
  File "readthedocs/doc_builder/director.py", line 251, in create_environment
    self.language_environment.setup_base()
  File "readthedocs/doc_builder/python_environments.py", line 361, in setup_base
    self._append_core_requirements()
  File "readthedocs/doc_builder/python_environments.py", line 398, in _append_core_requirements
    self.config.conda.environment,

[stsewd]

How did we ended up into _append_conda_requirements if the build is not a Conda build?

It's a conda build https://code.usgs.gov/wma/nhgf/toolsteam/gdptools/-/blob/aae8a912213b856a903ee566ccafa5b3b503ccba/.readthedocs.yml#L9-10

[humitos]

Oh, the thing is that build.tools.python: "miniconda" does require conda.environment and it's not defined in that config file. We should make a note in the docs if we are not already and make the config file to validate this case.

[humitos]

This could be handled at #10502 and #9008 as well. So, I'm linking that issue here and closing this one.