Skip to content

Non active but hidden versions are stuck in a redirect loop #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicolasMassart opened this issue Aug 9, 2022 · 6 comments
Closed

Non active but hidden versions are stuck in a redirect loop #9485

NicolasMassart opened this issue Aug 9, 2022 · 6 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related

Comments

@NicolasMassart
Copy link

NicolasMassart commented Aug 9, 2022

Details

Hi, was trying to figure out how to make a version inactive and have it redirect to the default (latest) version.
It seems that the behaviour is broken when the version is hidden.
Currently when I uncheck the active box on a version but keep the hidden box checked, if I try to go to the version doc, it get stuck in a redirect loop and browser displays a "too many redirect" error.

This works well if both Active and Hidden are unchecked.

Expected Result

Non active AND hidden versions should redirect to the default version.

Exemple: https://besu.hyperledger.org/en/1.5.0/Concepts/Privacy/Privacy-Overview/ -> https://besu.hyperledger.org/en/stable/Concepts/Privacy/Privacy-Overview/

Actual Result

Non active AND hidden versions are stuck in a redirect loop. The page returns a 302 redirect to the same address.
Exemple https://besu.hyperledger.org/en/1.5.0/Concepts/Privacy/Privacy-Overview/ returns ERR_TOO_MANY_REDIRECTS

@NicolasMassart NicolasMassart changed the title Non active versions are stuck in a redirect loop Non active but hidden versions are stuck in a redirect loop Aug 9, 2022
@humitos
Copy link
Member

humitos commented Aug 9, 2022

Hi @NicolasMassart. Do you have set up a redirect?

I think this is a duplicate of #9335. I guess that Read the Docs is not deleting the HTML files from the storage when you mark a version as active=False, and I think it should. That would solve this issue, I guess.

@NicolasMassart
Copy link
Author

I have redirects but they should not interact with this I guess.
redirects list screenshot
Maybe it's a dup of the issue you linked. If so, feel free to close this one.

@humitos
Copy link
Member

humitos commented Aug 9, 2022

Thanks for your quick reply. I don't think it's a problem with the redirects, yeah. I added the other issue as planned to the roadmap. Hopefully, we can prioritize it soon. Please, subscribe there to receive notifications.

@NicolasMassart
Copy link
Author

Also note that the use of hidden on an inactive version is totally useless. If it's inactive it not accessible even in a hidden way.
But as it generates a bug, I wanted to make sure we know.
On my side I changed all the inactive versions hidden status to false with the API (except the one linked in this issue as example). So I'm good, no blocker.

@humitos
Copy link
Member

humitos commented Aug 9, 2022

Also note that the use of hidden on an inactive version is totally useless

You have a point here 👍🏼 . This should not be allowed by the UI -it does not make sense to me.

@humitos humitos added Design Design or UX/UI related Bug A bug Accepted Accepted issue on our roadmap labels Aug 9, 2022
@stsewd
Copy link
Member

stsewd commented May 4, 2023

This was solved with #9335.

@stsewd stsewd closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug Design Design or UX/UI related
Projects
None yet
Development

No branches or pull requests

3 participants