Skip to content

Show a proper error message if the build exceeded the number of retries #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Apr 27, 2022 · 1 comment
Closed
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@stsewd
Copy link
Member

stsewd commented Apr 27, 2022

Currently if the number of retries is reached (25)

RTD_BUILDS_MAX_RETRIES = 25

An exception will be raised (BuildMaxConcurrencyError), and we will be hitting this code

elif isinstance(exc, BuildUserError):
if hasattr(exc, 'message') and exc.message is not None:
self.data.build['error'] = exc.message

that code just updates the build to the same error as Concurrency limit reached (2), retrying in 5 minutes, and mark the build as failed, that isn't accurate as the build will not be retried.

@humitos
Copy link
Member

humitos commented Apr 27, 2022

I think this is a dup of #9011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants