Unskip `test_get_env_vars_default` test #9058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

stsewd opened this issue Mar 30, 2022 · 0 comments

Labels

Accepted Needed: tests

Member

stsewd commented Mar 30, 2022

A feature was removed without us noticing it because this test wasn't executed

readthedocs.org/readthedocs/projects/tests/test_build_tasks.py

Lines 186 to 189 in dd73d84

    
           @mock.patch("readthedocs.doc_builder.director.load_yaml_config") 
        
           @pytest.mark.skip() 
        
           # NOTE: find a way to test we are passing all the environment variables to all the commands 
        
           def test_get_env_vars_default(self, load_yaml_config):

ref #9052 (review)

humitos added Needed: tests Accepted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment