Skip to content

Custom domain: remove support of custom domains on subprojects? #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Mar 1, 2022 · 0 comments · Fixed by #8953
Closed

Custom domain: remove support of custom domains on subprojects? #8985

stsewd opened this issue Mar 1, 2022 · 0 comments · Fixed by #8953
Assignees
@stsewd
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Mar 1, 2022 •
edited
Loading

Currently, we are going to warn users that are about adding a custom domain to a subproject.
But is there a real use case to allow them?

One use case I can think of is about having short URLs (linking to sub.example.com/en/latest/foo.html instead of main.example.com/projects/subproject/en/latest/foo.html).

ref #8945 (comment)
@stsewd stsewd added the Needed: design decision A core team decision is required label Mar 1, 2022
This was referenced Mar 1, 2022
Merged
Merged
@ericholscher ericholscher moved this to In progress in 📍Roadmap Mar 25, 2022
@stsewd stsewd moved this from In progress to Needs review in 📍Roadmap Apr 13, 2022
@ericholscher ericholscher linked a pull request May 3, 2022 that will close this issue
Custom domains: don't allow adding a custom domain on subprojects #8953
Merged
Repository owner moved this from Needs review to Done in 📍Roadmap May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
Needed: design decision A core team decision is required
Projects
📍Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom domains: don't allow adding a custom domain on subprojects readthedocs/readthedocs.org
1 participant
@stsewd