Skip to content

Project slugs with multiple dashes can't load PR builds #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Nov 20, 2021 · 1 comment · Fixed by #8700
Closed

Project slugs with multiple dashes can't load PR builds #8699

agjohnson opened this issue Nov 20, 2021 · 1 comment · Fixed by #8700
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@agjohnson
Copy link
Contributor

For a period of time, projects could end up with a slightly invalid slug, with double dashes. This could happen if the project name included a utf8 character that would not slugify or even a dash/underscore. New projects seem to slug properly now, but for any project that was created in the period where these slugs were possible, PR builds will not work due to pattern matching bugs.

The logic here simply breaks up the first --, which for a project slug like slug--bug--1.org.readthedocs.build, would not parse correctly. Bug is here:

project_slug, version_slug = host_parts[0].split('--', 1)

@agjohnson agjohnson added Bug A bug Accepted Accepted issue on our roadmap labels Nov 20, 2021
@agjohnson
Copy link
Contributor Author

I put up a PR, but not entirely sure it resolves the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant