Skip to content

Do not upload HTML if non-HTML output fails #8615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Oct 26, 2021 · 2 comments
Closed

Do not upload HTML if non-HTML output fails #8615

humitos opened this issue Oct 26, 2021 · 2 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: replication Bug replication is required

Comments

@humitos
Copy link
Member

humitos commented Oct 26, 2021

It seems that we are uploading the HTML output immediately after it completes. However, it may happen that the build fails after that because the PDF output fails or for any other reason.

We should double-check what's the status of this and upload all the outputs at once after we are sure the build passed.


@humitos Because HTML was being uploaded directly after it was built to increase the speed of publishing. I thought we'd reverted this, but if we haven't we should. I agree it shouldn't publish if the build doesn't pass.

There is also the issue of the PDF builds failing even while producing valid output, but that's a different issue.

Originally posted by @ericholscher in #8612 (comment)

@humitos
Copy link
Member Author

humitos commented Jul 24, 2023

We could double-check this in code because I think we have changed the pattern here and we always upload everything after the build was built successfully.

@humitos
Copy link
Member Author

humitos commented Jul 24, 2023

Yes, we upload all the artifacts after the build process has finished:

self.store_build_artifacts()

@humitos humitos closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: replication Bug replication is required
Projects
None yet
Development

No branches or pull requests

1 participant