Skip to content

Add tests for build/version/project django filters #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
agjohnson opened this issue Jun 7, 2021 · 2 comments
Open

Add tests for build/version/project django filters #8238

agjohnson opened this issue Jun 7, 2021 · 2 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required

Comments

@agjohnson
Copy link
Contributor

In #8142 a number of filters were added, and need some test coverage. Noting here as the underlying PR skipped adding more test coverage to the views for now.
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jun 7, 2021
@agjohnson agjohnson mentioned this issue Jun 7, 2021
Merged
@humitos humitos added the Needed: tests Tests are required label Jun 8, 2021
@astrojuanlu
Copy link
Contributor

Side question: is it worth having coverage checks on this repository? I've been using https://about.codecov.io/ for some time

@stsewd
Copy link
Member

stsewd commented Jun 10, 2021

Side question: is it worth having coverage checks on this repository? I've been using https://about.codecov.io/ for some time

We do use codecov https://app.codecov.io/gh/readthedocs/readthedocs.org, just isn't enabled to mark a PR as failed, it was for some time, but the team didn't like it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@humitos @astrojuanlu @agjohnson @stsewd