Skip to content

Enable DONT_OVERWRITE_SPHINX_CONTEXT for tapir-scala #8091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamw opened this issue Apr 12, 2021 · 7 comments
Closed

Enable DONT_OVERWRITE_SPHINX_CONTEXT for tapir-scala #8091

adamw opened this issue Apr 12, 2021 · 7 comments
Labels
Support Support question

Comments

@adamw
Copy link

adamw commented Apr 12, 2021

I need to overwrite the conf_py_path context value, so that the "Edit on github" links are properly generated on https://tapir.softwaremill.com/en/latest/ - they currently point to the generated-doc directory, instead of the doc directory (there's an additional docs type-checking step during a release).

I've tried following https://docs.readthedocs.io/en/latest/guides/vcs.html and defining the html_contex as specified there - this works locally, but not on rtd:

html_context = {
    'display_github': True, # Integrate GitHub
    'github_user': 'softwaremill', # Username
    'github_repo': 'tapir', # Repo name
    'github_version': 'master', # Version
    'conf_py_path': '/doc/', # Path in the checkout to the docs root
}

I then found #2971, and as I understand, I need the DONT_OVERWRITE_SPHINX_CONTEXT feature flag enabled. I tried doing this by defining an environment variable, but this doesn't seem to work.

Can this feature be enabled for the tapir-scala project, or maybe there's a better way to adjust the "Edit on GitHub" link?

@stsewd
Copy link
Member

stsewd commented Apr 12, 2021

I have added that feature flag to your project, it should link to the correct page no https://tapir.softwaremill.com/en/latest/

@stsewd stsewd closed this as completed Apr 12, 2021
@stsewd stsewd added the Support Support question label Apr 12, 2021
@adamw
Copy link
Author

adamw commented Apr 13, 2021

@stsewd Works, thank you very much! Sorry for not mentioning this outright, could you do the same for the sttp project? It uses the same mechanism.

@stsewd
Copy link
Member

stsewd commented Apr 13, 2021

@adamw done!

@adamw
Copy link
Author

adamw commented Apr 13, 2021

@stsewd Thanks again! :)

@ghostbuster91
Copy link

@stsewd Can I ask for the same for the https://github.com/softwaremill/diffx project? It uses the same mechanism.

@humitos
Copy link
Member

humitos commented Jul 26, 2021

@ghostbuster91 Hi! Please, send us an email to [email protected] and let us know the URL of your project under Read the Docs (not the GH, one). Thanks!

@ghostbuster91
Copy link

@humitos I'll do that, thanks for the info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

4 participants