Skip to content

Remove deprecated/unused Django settings #8041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Mar 23, 2021 · 1 comment
Closed

Remove deprecated/unused Django settings #8041

humitos opened this issue Mar 23, 2021 · 1 comment
Assignees
Labels
Accepted Accepted issue on our roadmap Needed: patch A pull request is required
Milestone

Comments

@humitos
Copy link
Member

humitos commented Mar 23, 2021

There are some Django settings that are not used anymore, are deprecated or they just fail when using a different value.

  • DOCKER_ENABLED: we don't really support using False for this
  • USE_SUBDOMAIN: people using local instances setup has reported that it doesn't work when using False
  • MULTIPLE_APP_SERVERS: we don't use this setting anymore (Remove broadcast function #7044)
  • [add more settings here]

Ref: #7994 (comment)

@humitos humitos added Needed: patch A pull request is required Accepted Accepted issue on our roadmap labels Mar 23, 2021
@humitos humitos added this to the Refactoring milestone Mar 23, 2021
@humitos humitos self-assigned this Mar 12, 2022
@humitos
Copy link
Member Author

humitos commented Feb 16, 2023

We should audit all our settings. There are plenty that are not used anymore. See https://github.com/readthedocs/readthedocs-ops/pull/926#discussion_r603594435 for a simple idea about how to do it.

@humitos humitos closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Needed: patch A pull request is required
Projects
None yet
Development

No branches or pull requests

1 participant