Skip to content

Remove six dependency for builds #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Dec 1, 2020 · 0 comments · Fixed by #7890
Closed

Remove six dependency for builds #7717

humitos opened this issue Dec 1, 2020 · 0 comments · Fixed by #7890
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Dec 1, 2020

Our build process is depending on six because we use it in our conf.py.tmpl

readthedocs.org/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl

Line 20 in d66f9b1

from six import string_types

We could just copy the relevant code from six module there and remove the dependency.

Sphinx<2 installs it as a dependency, but newer Sphinx versions don't.

See #7710 (and linked issues) for more details
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Dec 1, 2020
@ericholscher ericholscher added the Good First Issue Good for new contributors label Dec 1, 2020
@stsewd stsewd mentioned this issue Jan 25, 2021
Closed
@stsewd stsewd mentioned this issue Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop six readthedocs/readthedocs.org
2 participants
@ericholscher @humitos