Skip to content

Enable docs-linkcheck test #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Oct 28, 2020 · 3 comments · Fixed by #9091
Closed

Enable docs-linkcheck test #7612

humitos opened this issue Oct 28, 2020 · 3 comments · Fixed by #9091
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on

Comments

@humitos
Copy link
Member

humitos commented Oct 28, 2020

On #7603 we disabled this check because CircleCI does not allow failure.

This check is a nice to have that we should find a way to re-enable in the future.
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Oct 28, 2020
@stsewd
Copy link
Member

stsewd commented Nov 25, 2020

This may fix the retry failures sphinx-doc/sphinx#8467

@humitos humitos added Good First Issue Good for new contributors Sprintable Small enough to sprint on labels Mar 18, 2021
@astrojuanlu
Copy link
Contributor

Is this meant for our own docs, or for RTD builds in general?

@humitos
Copy link
Member Author

humitos commented Sep 2, 2021

Only for our docs.

@humitos humitos mentioned this issue Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: call linkcheck Sphinx builder for our docs readthedocs/readthedocs.org
3 participants
@humitos @astrojuanlu @stsewd