-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
.inv files are over-cached? #7590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like the cache expired after 90 minutes. |
Thanks for the report. The cache for a particular version should be purged immediately (couple of minutes, not 90 as you mentioned) after the build for that version succeed. We will need to have more debugging information here to be able to find out the reason. Anything else that you can provide? Can you do some other tests here and check the HTTP headers: We have an alarm in our system that checks the latency since the build was triggered until the new content is published and online, and we are not noticing this 90 minutes cached delay that you are mentioning. |
Here is header information: Requesting objects.inv after 90 minutes have passed since the build:
Requesting objects.inv right after a build, the old content is served:
Requesting objects.inv with a query param to bust the cache:
|
A more careful test showed that wget got updated content an hour after the build. That meshes well will the "Cache-Control: public, max-age=3600" header. |
I think I found the issue and I'd say that's a bug in our task that purge the cache. It gets confused when generating tags cache for subprojects. For your particular case, when hitting The |
@nedbat we just deployed the fix for this, could you confirm us that this is working as you expected now and the cache is being invalidated "immediately" (minutes) after the build is done? Thanks! |
I tested it, and it works! My branch got an updated objects.inv right away. Thanks! |
Details
Expected Result
We have a multi-book docset, with references between the books. We use an intersphinx_mapping to resolve these references:
(The "learners" reference is to a particular branch so that my new references will be found as I work on the pull request.)
When I update one book, I find the next local build still can't resolve the new references. Using wget to pull the .inv file, it seems that the old content is still being served, but if I add a nonsense query parameter, I get the new content:
I saw the problem yesterday, and then new references seemed to resolve this morning, so it seems that waiting long enough will bring the new content, as if a cache expires. I don't know how long that time is.
The text was updated successfully, but these errors were encountered: