Skip to content

Notified of a failed build that does not exist #7587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pllim opened this issue Oct 21, 2020 · 2 comments · Fixed by #8815
Closed

Notified of a failed build that does not exist #7587

pllim opened this issue Oct 21, 2020 · 2 comments · Fixed by #8815
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@pllim
Copy link
Contributor

pllim commented Oct 21, 2020

Details

Expected Result

No notification about a failed build if the build succeeded.

Actual Result

Got the following email notification but when I checked the build, it was successful (or in a previous occurence, still building). This is not the only time such a situation happened. It has happened with different build IDs in the past few days, but perhaps not for every build?


From: Read the Docs
Sent: Tuesday, October 20, 2020 8:51 PM
Subject: Failed: Astropy (f39a33a3)

Astropy build #12149040

Build Failed for Astropy (latest)

Error: There was a problem with Read the Docs while building your documentation. Please try again later. However, if this problem persists, please report this to us with your build id (12149040).

You can find out more about this failure here:

Astropy build #12149040 - failed

If you have questions, a good place to start is the FAQ:

https://docs.readthedocs.io/page/faq.html

You can unsubscribe from these emails in your Notification Settings

Keep documenting,
Read the Docs

Read the Docs
https://readthedocs.org

@humitos
Copy link
Member

humitos commented Oct 21, 2020

Thanks for your report. I think I know what happened here. In some scenarios when the build fails (the process is killed for some reason and don't remove the celery task from redis), we retry it.

So, we probably sent the notification for the failed build. Then retry, and finally it succeeded. In fact, if you check the build output, you will see the git clone was done twice, that's because it failed immediately before the second git clone and we retry after that.

Unfortunately, we don't have a great solution for this yet.

@humitos humitos added Accepted Accepted issue on our roadmap Bug A bug labels Oct 21, 2020
@pllim
Copy link
Contributor Author

pllim commented Oct 21, 2020

Ah, thanks for the explanation! I am glad I am not going crazy over here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants