Skip to content

Edit on github link follows symbolic link directly - creates wrong URL #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrometheusPi opened this issue Sep 23, 2020 · 3 comments
Closed
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@PrometheusPi
Copy link

Details

Expected Result

The "Edit on Github" button on https://picongpu.readthedocs.io/en/latest/examples/LaserWakefield/README.html
should link to https://github.com/ComputationalRadiationPhysics/picongpu/blob/dev/share/picongpu/examples/LaserWakefield/README.rst.

Actual Result

The "Edit on Github" button actually link to https://github.com/ComputationalRadiationPhysics/picongpu/tree/dev/docs/source/examples/LaserWakefield/README.rst.

- https://github.com/ComputationalRadiationPhysics/picongpu/blob/dev/docs/source/examples/LaserWakefield/README.rst
+ https://github.com/ComputationalRadiationPhysics/picongpu/blob/dev/share/picongpu/examples/LaserWakefield/README.rst

This is most likely caused by the symbolic link https://github.com/ComputationalRadiationPhysics/picongpu/blob/dev/docs/source/examples that points from the general documentation directory to the a documentation if the examples.

The documentation is pared fine and in a standalone sphinx build, a txt of the rst file is generated and linked correctly. Only the link is erroneous.

@stsewd
Copy link
Member

stsewd commented Sep 24, 2020

I don't think we have a way to detect if a file was generated from a symlink, I think the VCS provider (github) should be in charge of redirect to the correct file. Similar to #4043

@PrometheusPi
Copy link
Author

@stsewd Thank you for the information.

@stsewd stsewd added the Needed: design decision A core team decision is required label Sep 28, 2020
@stsewd stsewd added the Improvement Minor improvement to code label Dec 10, 2020
@humitos
Copy link
Member

humitos commented Sep 15, 2023

I'm closing this issue since there isn't too much we can do here. We will be discussing how to make this feature work in a reliably way for the new implementation of the flyout in #10742

@humitos humitos closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants