Skip to content

Race condition when a version is building and it's marked as inactive #7224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stsewd opened this issue Jun 23, 2020 · 1 comment
Open

Race condition when a version is building and it's marked as inactive #7224

stsewd opened this issue Jun 23, 2020 · 1 comment
Assignees
@humitos
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Jun 23, 2020

There is a race condition when a user marks as inactive a version while it's building, at the end we will end up with indexed data and html files of the inactive version (the deletion happens first, but then we upload the files again when the build finish). We could have a periodic task for this, check all inactive versions and delete any resources left.
@stsewd stsewd added the Needed: design decision A core team decision is required label Jun 23, 2020
@humitos
Copy link
Member

humitos commented Jan 27, 2022

I think this can be solved using the same approach than for cancel a build. See #8850

@humitos humitos self-assigned this Jan 27, 2022
@humitos humitos mentioned this issue Feb 3, 2022
Merged
@humitos humitos added Accepted Accepted issue on our roadmap Improvement Minor improvement to code and removed Needed: design decision A core team decision is required labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humitos @stsewd