Skip to content

Add [x] to close site notifications #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericholscher opened this issue May 8, 2020 · 3 comments
Closed

Add [x] to close site notifications #11

ericholscher opened this issue May 8, 2020 · 3 comments

Comments

@ericholscher
Copy link
Member

I've had a few users who have been confused by the inability to close our in-site notifications. Currently you can click on any of the links to close them, but we should also add an [x] in the corner to close them, as that's the standard UX for this.

@stsewd
Copy link
Member

stsewd commented May 8, 2020

Same as readthedocs/readthedocs.org#6601, feel free to close the other one, since this one is more specific.

@agjohnson
Copy link
Contributor

I won't address this in our current templates. Our new templates will already have this though.

@agjohnson agjohnson transferred this issue from readthedocs/readthedocs.org May 20, 2020
@ericholscher
Copy link
Member Author

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants