Skip to content

How to enable query parameters in redirects? #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgeier opened this issue Apr 17, 2020 · 4 comments · Fixed by #6957
Closed

How to enable query parameters in redirects? #6922

mgeier opened this issue Apr 17, 2020 · 4 comments · Fixed by #6957
Labels
Bug A bug

Comments

@mgeier
Copy link
Contributor

mgeier commented Apr 17, 2020

I don't really understand how any of this works under the covers, but since #5081 has been merged this should be supported, right?

For example, I have set the default version of my project to 0.6.0, so it correctly redirects https://nbsphinx.readthedocs.io/ to https://nbsphinx.readthedocs.io/en/0.6.0/.

However, when I use the search URL with a query parameter, the parameter is somehow lost in redirection:

Expected Result

https://nbsphinx.readthedocs.io/search.html?q=readthedocs should get redirected to https://nbsphinx.readthedocs.io/en/0.6.0/search.html?q=readthedocs

Actual Result

https://nbsphinx.readthedocs.io/search.html?q=readthedocs gets redirected to https://nbsphinx.readthedocs.io/en/0.6.0/search.html

@stsewd stsewd added the Bug A bug label Apr 20, 2020
@stsewd
Copy link
Member

stsewd commented Apr 20, 2020

This looks like a regression from our new proxy server

@ericholscher
Copy link
Member

@mgeier What is the redirect that you have configured on your project for this case?

@ericholscher
Copy link
Member

We figured out the issue, and should have a patch deployed next week.

@stsewd
Copy link
Member

stsewd commented Apr 28, 2020

This is out now, you may still see https://nbsphinx.readthedocs.io/search.html?q=readthedocs not redirecting properly bc of your browser cache. Other works https://nbsphinx.readthedocs.io/search.html?q=testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants