Skip to content

Mark builds as failed when setup.py fails #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eugeny opened this issue Feb 17, 2014 · 2 comments
Closed

Mark builds as failed when setup.py fails #682

Eugeny opened this issue Feb 17, 2014 · 2 comments
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on

Comments

@Eugeny
Copy link

Eugeny commented Feb 17, 2014

If virtualenv was enabled, it's almost certain that user looks for having his autodoc pages work with dependent packages being imported. However if virtualenv population fails (e.g. missing package or datafile placement permission denied), build is still marked as passed. However it will most certainly lead to empty doc pages.
@ericholscher
Copy link
Member

Not sure the best way to handle this. I like the idea of just aborting builds at a failed setup.py though. I imagine there are times when this isn't the desired behavior, and it's reasonably backwards incompatible though. Will have to think more about it.

@ericholscher
Copy link
Member

This should be fixed now with #1524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericholscher @Eugeny