Skip to content

Initialize all the attributes in build tasks on __init__ method #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Dec 10, 2019 · 6 comments · Fixed by #8815
Closed

Initialize all the attributes in build tasks on __init__ method #6452

stsewd opened this issue Dec 10, 2019 · 6 comments · Fixed by #8815
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority Sprintable Small enough to sprint on
Milestone

Comments

@stsewd
Copy link
Member

stsewd commented Dec 10, 2019

Move all the self attributes to the __init__ method and work from there, right now we initialize the attributes around all the places.

class SyncRepositoryTaskStep(SyncRepositoryMixin):

class UpdateDocsTaskStep(SyncRepositoryMixin):

Ref #6451 (comment)

Edit: I edit the title and the description a little.

@stsewd stsewd added the Improvement Minor improvement to code label Dec 10, 2019
@stsewd stsewd added this to the Refactoring milestone Dec 10, 2019
@KartikKapil
Copy link
Contributor

KartikKapil commented Dec 16, 2019

@stsewd {class UpdateDocsTaskStep(SyncRepositoryMixin)} already has a init method do i need to look for more attributes of the same class to be added to the init method .

@stsewd
Copy link
Member Author

stsewd commented Dec 16, 2019

@KartikKapil we need to refactor all that code, maybe move it out of the tasks.py file. This isn't a good first issue if you are not familiar with the codebase, but feel free to try

@KartikKapil
Copy link
Contributor

@stsewd i wanted to give it a try , thank you :)

@Blackcipher101
Copy link
Contributor

@stsewd Can I give this issue a try

@stale
Copy link

stale bot commented Mar 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Mar 1, 2020
@stsewd stsewd added Priority: low Low priority and removed Status: stale Issue will be considered inactive soon labels Mar 2, 2020
@stale
Copy link

stale bot commented Apr 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Apr 16, 2020
@humitos humitos changed the title Move all related build code to a class Initialize all the attributes in build tasks on __init__ method Apr 16, 2020
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Apr 16, 2020
@stsewd stsewd added the Accepted Accepted issue on our roadmap label Apr 16, 2020
@humitos humitos added the Sprintable Small enough to sprint on label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority Sprintable Small enough to sprint on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants