-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Initialize all the attributes in build tasks on __init__
method
#6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stsewd {class UpdateDocsTaskStep(SyncRepositoryMixin)} already has a init method do i need to look for more attributes of the same class to be added to the init method . |
@KartikKapil we need to refactor all that code, maybe move it out of the tasks.py file. This isn't a good first issue if you are not familiar with the codebase, but feel free to try |
@stsewd i wanted to give it a try , thank you :) |
@stsewd Can I give this issue a try |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
__init__
method
Move all the self attributes to the
__init__
method and work from there, right now we initialize the attributes around all the places.readthedocs.org/readthedocs/projects/tasks.py
Line 216 in c2609f5
readthedocs.org/readthedocs/projects/tasks.py
Line 301 in c2609f5
Ref #6451 (comment)
Edit: I edit the title and the description a little.
The text was updated successfully, but these errors were encountered: