Skip to content

Cache in footer view #6126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Aug 30, 2019 · 4 comments
Closed

Cache in footer view #6126

stsewd opened this issue Aug 30, 2019 · 4 comments
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Aug 30, 2019

The footer view is assessed for each page view. We should make it faster :)

Ref: #6125 (comment)

@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Aug 30, 2019
@humitos
Copy link
Member

humitos commented Sep 4, 2019

Cache keys should be improved to avoid potential conflicts: https://github.com/readthedocs/readthedocs.org/pull/6125/files#r320606597

@tapaswenipathak
Copy link
Contributor

Hi folks: I have added few PRs, let me know your thoughts #6148 (comment).

@dojutsu-user
Copy link
Member

@stsewd I think it will result in not having correct results for #6121. We are storing the page views count from the footer views. So if that is cached -- the page view count will not be correct.

@stsewd
Copy link
Member Author

stsewd commented Dec 9, 2020

We are going to move page views to its own endpoint #7739, after that we are going to cache it trough cloudflare.

@stsewd stsewd closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants