Skip to content

Setup vale linter bot #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
humitos opened this issue Jul 2, 2019 · 11 comments
Open

Setup vale linter bot #5876

humitos opened this issue Jul 2, 2019 · 11 comments
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jul 2, 2019

vale is a linter that we can add to our CI or even a GitHub bot to validate our documentation. This will allow us to avoid the usage of RTD instead of Read the Docs and other branding words, for example.

It would be pretty handy to setup it in our repository: https://github.com/apps/vale-linter

@humitos humitos added Good First Issue Good for new contributors Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jul 2, 2019
@pranay414
Copy link
Contributor

@humitos I've worked with github apps and I would like to work on this issue.

@humitos
Copy link
Member Author

humitos commented Jul 3, 2019

Please, go ahead. I've never done it before, so you will need to research a little to configure it by yourself. I can help you by reviewing the PR after that.

@pranay414
Copy link
Contributor

@humitos Sure, that'll be great.

@pranay414
Copy link
Contributor

@humitos can you tell me the list of lint checks that needs to be performed?

@humitos
Copy link
Member Author

humitos commented Jul 8, 2019

For now a simple list like,

rtd
RtD
RTD

that change it to Read the Docs it's fine. We can add more later once it's setup.

@pranay414
Copy link
Contributor

@humitos I went through the source code of vale-linter-bot and it currently lints only markdown files but we want it to lint reStructured Text right?

@humitos
Copy link
Member Author

humitos commented Jul 10, 2019

Yes, I've never used it though

Although, in the page that I liked in the description it says

Vale is a natural language linter that supports plain text, markup (Markdown, reStructuredText, AsciiDoc, and HTML), and source code comments.

@pranay414
Copy link
Contributor

pranay414 commented Jul 11, 2019

@humitos Vale is a CLI to lint plain text, markup (Markdown, reStructuredText, AsciiDoc, and HTML), and source code comments. On the other hand vale-linter-bot is a bot which runs Vale to lint only Markdown files. I think we can do one of the following things:

  1. Fork vale-linter-bot and customise it to lint all types of file or maybe file an issue in that repo to resolve it.
  2. Set up Vale as an editor extension.
    What do you think?

@santos22
Copy link
Contributor

Is this still a need? Happy to continue the investigation.

@santos22 santos22 mentioned this issue May 26, 2020
3 tasks
@santos22
Copy link
Contributor

@humitos @stsewd #7126 should close this.

The failed build is due to the linting errors which I have not fixed yet so others can see how it works. I'd also like to follow up on the other checks mentioned in the pull request.

@ppansare
Copy link

Is the Vale-linter bot still needed? I am working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
4 participants