Skip to content

Github integration ignores source_suffix #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lazka opened this issue Dec 3, 2013 · 8 comments
Closed

Github integration ignores source_suffix #559

lazka opened this issue Dec 3, 2013 · 8 comments

Comments

@lazka
Copy link
Contributor

lazka commented Dec 3, 2013

Example: https://python-gtk-3-tutorial.readthedocs.org/en/latest/index.html

The repo uses ".txt" as source_suffix which breaks the "Edit on GitHub" link.

See sebp/PyGObject-Tutorial#24

@ericholscher
Copy link
Member

That is indeed annoying. I'll take a look at it this week.

@groovecoder
Copy link
Contributor

This is close to the other issue I worked on, so I'll give this a shot too.

@groovecoder
Copy link
Contributor

It looks like we need to access the source_suffix setting value from the project's conf.py module to make this work. But that seem ... daunting. I don't see any other place in sphinx-building code where we import any values from a project's conf module ... would this be the first time to do it?

@ericholscher
Copy link
Member

This should now be fixed.

@lazka
Copy link
Contributor Author

lazka commented Apr 15, 2014

Thanks!

@mgeier
Copy link
Contributor

mgeier commented Dec 16, 2015

This still doesn't work if source_suffix is a list of suffixes!
It seems that only the first element of the list is taken into account.

@agjohnson
Copy link
Contributor

@mgeier can you please open a separate issue to address the problem you're describing? The original issue here has been resolved for a while now.

@mgeier
Copy link
Contributor

mgeier commented Dec 22, 2015

@agjohnson: OK, done: #1871.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants