Skip to content

Add analytics code per-version using a config file #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Mar 18, 2019 · 3 comments
Closed

Add analytics code per-version using a config file #5478

stsewd opened this issue Mar 18, 2019 · 3 comments
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Mar 18, 2019

This is currently a per-project option currently.

Ref #5459 (comment)

My doubt about this: Don't people use just one analytics code per site? And also, isn't a way of identify each page from analytics?

Also, one good thing is people changing their analytics code over time.

@stsewd stsewd added Feature New feature Needed: design decision A core team decision is required labels Mar 18, 2019
@humitos
Copy link
Member

humitos commented Apr 28, 2019

@davidfischer can you expand here? I'm not sure if in your linked comment you refer specifically to the analytics_code setting or another portion of that code.

I'm not sure to understand why having an analytics_code per version would be useful.

@davidfischer
Copy link
Contributor

I missed this when it was opened but I'm glad you followed up.

For the vast majority of cases, I suspect that all versions of a project would want the same analytics code. With that said, I could envision a case where certain versions don't want to send data to GA. The bigger advantage I see is that this adds the analytics code to version control rather than having a project level setting.

@davidfischer
Copy link
Contributor

Looking back, nobody has given a use case for making analytics per version. If the setting is project-wide and not version specific, I'm in favor of closing this and making it a project level setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

4 participants