Sitemap does not include HTTPS links for custom domains

[strophy]

The generated sitemap.xml gets the URL for each available version by calling get_docs_url. For custom domains, this returns HTTP links, which perform a 301 redirect to the HTTPS version. But sitemaps should only point to actual pages (references: Google, Bing) and not redirects, or the crawler may begin losing trust in the sitemap and put a penalty on the information it contains.

Also, the docstring for this method is probably incorrect, as noted here. This method actually returns HTTPS links for non-custom domains. Related issue: #4641

Example: https://docs.dash.org/sitemap.xml

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dojutsu-user]

Still valid bot.

[humitos]

Marking the issue as Accepted since is something we want to fix.

[KartikKapil]

hello @humitos i would like take this issue up what exactly do i need to do for this ???

[humitos]

Hi @KartikKapil! The requirements for this issue are in the description of the issue. Is there any particular point that you don't understand from there?

[KartikKapil]

@humitos i could not figure out that how to change the function" get_docs_url" to make sure it points to the pages but does not redirect

[ashadhaz]

Hey @humitos I would like to work on this issue. Is it still open?

[humitos]

@ashadhaz yes, it's still open

[Parth1811]

@ashadhaz are you still working on this issue? If not I would like to work on this.

[Parth1811]

I am working on this issue as mentioned on IRC.

@stsewd how should this be fixed, there are two approaches:

1. Simply place https instead of http and expect the custom domain to have SSL.
2. In the get_docs_url method make a request and check if the domain has SSL and then proceed accordingly.

[ericholscher]

This is now fixed 👍