Skip to content

Refactor build_docs_html to use build_docs_class #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Mar 6, 2019 · 8 comments
Closed

Refactor build_docs_html to use build_docs_class #5410

stsewd opened this issue Mar 6, 2019 · 8 comments
Assignees
@humitos
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority
Milestone
Refactoring

Comments

@stsewd
Copy link
Member

stsewd commented Mar 6, 2019

build_docs_html

https://github.com/rtfd/readthedocs.org/blob/4911600c230809bd6fb3585d1903121db2928ad6/readthedocs/projects/tasks.py#L839-L839

should use https://github.com/rtfd/readthedocs.org/blob/4911600c230809bd6fb3585d1903121db2928ad6/readthedocs/projects/tasks.py#L903-L917

as the other builders and not be a special case.
@stsewd stsewd added Improvement Minor improvement to code Priority: low Low priority labels Mar 6, 2019
@stsewd stsewd added this to the Refactoring milestone Mar 6, 2019
@stsewd stsewd mentioned this issue Mar 6, 2019
Closed
@Iamshankhadeep
Copy link
Contributor

Can I work on it? I think it is easy enough to solve. but still I am new to this community so learning everything I can.

@krutik710
Copy link

@stsewd Has this issue been assigned to anyone?
If not I can start working on it!

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 31, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label Jun 1, 2019
@stsewd
Copy link
Member Author

stsewd commented Jun 1, 2019

Feel free to take this issue!

@saadmk11
Copy link
Member

saadmk11 commented Jun 1, 2019

@stsewd if we use build_docs_class then what will happen to:
https://github.com/rtfd/readthedocs.org/blob/4911600c230809bd6fb3585d1903121db2928ad6/readthedocs/projects/tasks.py#L845-L847

as they depend on the builder but build_docs_class returns only success not the builder.

@stale
Copy link

stale bot commented Jul 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jul 16, 2019
@dojutsu-user dojutsu-user removed the Status: stale Issue will be considered inactive soon label Jul 16, 2019
@humitos humitos added Accepted Accepted issue on our roadmap and removed Accepted Accepted issue on our roadmap labels Jul 16, 2019
@stale
Copy link

stale bot commented Aug 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Aug 30, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Aug 30, 2019
@humitos humitos self-assigned this Jan 27, 2022
@humitos
Copy link
Member

humitos commented Mar 15, 2022

This was done in https://github.com/readthedocs/readthedocs.org/pull/9002/files#diff-2c0b1d043c9dce8c6517b5f5ee669e37a2b673e5b2263a6968f25364c942b351R311

@humitos humitos closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Priority: low Low priority
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
6 participants
@humitos @stsewd @krutik710 @Iamshankhadeep @saadmk11 @dojutsu-user