You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ericholscher yeah, the theme should handle this, but it could probably be present in other themes that don't take the readthedocssinglehtml builder into consideration. I can patch our theme if that sounds good
that don't take the readthedocssinglehtml builder into consideration
As a general comment, we should move away of these specific builder names probably and use a similar approach as the one used in hoverxref extension: we inject our own mixin that changes behavior only where we need it but does not override user's.
Search isn't supported in this kind of builders (search.html isn't included).
Building locally doesn't show the search box, but on rtd it's shown, because our builder is named
readthedocssinglehtml
Themes check only for https://github.com/rtfd/sphinx_rtd_theme/blob/8c31a26a79702a0ffbb2ee153d4bb054d58087ac/sphinx_rtd_theme/searchbox.html#L1-L1
Should we patch the theme? (problem will still present in other themes) or should we change the way we call our builder or override the builders
The text was updated successfully, but these errors were encountered: