Skip to content

Convert docsearch newlines into BR's #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericholscher opened this issue Jan 24, 2019 · 2 comments
Closed

Convert docsearch newlines into BR's #5168

ericholscher opened this issue Jan 24, 2019 · 2 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
3.3

Comments

@ericholscher
Copy link
Member

Currently the results are split in docsearch by a newline between headers and content. We output the newline, but it doesn't mean anything in HTML. We should visually distinguish this.

screenshot 2019-01-24 11 35 10
@ericholscher ericholscher added the Accepted Accepted issue on our roadmap label Jan 24, 2019
@agjohnson agjohnson added the Improvement Minor improvement to code label Jan 25, 2019
@agjohnson agjohnson added this to the 3.3 milestone Jan 25, 2019
@ericholscher ericholscher mentioned this issue Jan 30, 2019
Merged
@ericholscher
Copy link
Member Author

Ended up changing these to periods instead of
's as it looks better.

@stsewd
Copy link
Member

stsewd commented Feb 6, 2019

This was already done in #5197

@stsewd stsewd closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
3 participants
@ericholscher @agjohnson @stsewd