Skip to content

In doc search should display all results #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericholscher opened this issue Jan 24, 2019 · 0 comments
Closed

In doc search should display all results #5167

ericholscher opened this issue Jan 24, 2019 · 0 comments
Labels
Accepted Accepted issue on our roadmap Bug A bug
Milestone
3.3

Comments

@ericholscher
Copy link
Member

ericholscher commented Jan 24, 2019 •
edited
Loading

Currently in doc search is only showing the first text result from elastic search:

https://github.com/rtfd/readthedocs.org/blob/2063d2dcb1708776c6e8b5f57482471347b544de/readthedocs/core/static-src/core/js/doc-embed/search.js#L58

We should be showing all the results.

You can see the difference here:
@ericholscher ericholscher added the Accepted Accepted issue on our roadmap label Jan 24, 2019
@agjohnson agjohnson added the Bug A bug label Jan 25, 2019
@agjohnson agjohnson added this to the 3.3 milestone Jan 25, 2019
@ericholscher ericholscher mentioned this issue Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@ericholscher @agjohnson