Skip to content

Manage setup_vcs problems better #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Jan 15, 2019 · 3 comments · Fixed by #5118
Closed

Manage setup_vcs problems better #5114

humitos opened this issue Jan 15, 2019 · 3 comments · Fixed by #5118
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Jan 15, 2019

I introduced a bug at e0c84056e

If the repo is invalid (.setup_vcs fails), we catch the exception, log it and continue as if everything went correct.

https://github.com/rtfd/readthedocs.org/blob/19e709089d645ac712a4c16b06a6083dbacd0539/readthedocs/projects/tasks.py#L612-L636

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Jan 15, 2019
@stsewd
Copy link
Member

stsewd commented Jan 15, 2019

I guess it was merged before it was finished?

#4804 (comment)

@humitos
Copy link
Member Author

humitos commented Jan 15, 2019

I think you are right. I'd revert this PR for now and propose a better solution for this.

@stsewd
Copy link
Member

stsewd commented Jan 15, 2019

I guess we can remove the try except block only from self.sync_repo(). The another block was already catching a general exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants