We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I introduced a bug at e0c84056e
If the repo is invalid (.setup_vcs fails), we catch the exception, log it and continue as if everything went correct.
.setup_vcs
https://github.com/rtfd/readthedocs.org/blob/19e709089d645ac712a4c16b06a6083dbacd0539/readthedocs/projects/tasks.py#L612-L636
The text was updated successfully, but these errors were encountered:
I guess it was merged before it was finished?
#4804 (comment)
Sorry, something went wrong.
I think you are right. I'd revert this PR for now and propose a better solution for this.
I guess we can remove the try except block only from self.sync_repo(). The another block was already catching a general exception.
self.sync_repo()
Successfully merging a pull request may close this issue.
I introduced a bug at e0c84056e
If the repo is invalid (
.setup_vcs
fails), we catch the exception, log it and continue as if everything went correct.https://github.com/rtfd/readthedocs.org/blob/19e709089d645ac712a4c16b06a6083dbacd0539/readthedocs/projects/tasks.py#L612-L636
The text was updated successfully, but these errors were encountered: