Skip to content

Remove un-needed python dependencies #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Jan 13, 2019 · 3 comments
Closed

Remove un-needed python dependencies #5101

humitos opened this issue Jan 13, 2019 · 3 comments
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Milestone
Cleanup

Comments

@humitos
Copy link
Member

humitos commented Jan 13, 2019 •
edited
Loading

Reviewing #5100 I realized that we have dependencies like defusedxml but there are no from/import defusedxml in our entire code base. So, we should remove them and rely on the proper package installation to install the proper version of it (to keep the compatibility they want).

Probably the same happens with lxml and httplib2 and more. Please, consider finding out other cases here.

NOTE: if they are required for some reason that it's not explicit in the code (because it's an optional package for another package but make it works faster/better/whatever we need to add a comment above the requirement explaining it.
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jan 13, 2019
@humitos humitos added this to the Cleanup milestone Jan 13, 2019
@dojutsu-user
Copy link
Member

@humitos
I think there's no use case of beautifulsoup4 also.

@stsewd stsewd added the Good First Issue Good for new contributors label Mar 1, 2019
@Mike-Dai
Copy link
Contributor

Mike-Dai commented Mar 2, 2019

@humitos Can I work on this issue?

@humitos
Copy link
Member Author

humitos commented Mar 3, 2019

@Mike-Dai Yes. Go ahead.

@Mike-Dai Mike-Dai mentioned this issue Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
4 participants
@humitos @stsewd @dojutsu-user @Mike-Dai