Upgrade Django to 2.2

[humitos]

Django 2.2 LTS is scheduled to be released on April, 2019: https://www.djangoproject.com/download/#supported-versions

This is a meta issue to comment here all the things that need to be changed or considered before this date to start the migration in a smooth way.

We are currently using Django 1.11 LTS which its support ends on (at least) April, 2020.

[davidfischer]

Thanks for creating this. I also wanted to mention that I'm +1 on only taking LTS releases of Django going forward.

[dojutsu-user]

@humitos
This will be huge 🎉
Here is a non-exhaustive list of deprecated things:

• django.utils.functional.allow_lazy is removed (ref) Remove deprecated code #5341
• ForeignKey requires on_delete parameter.
• AutoOneToOneField from django-annoying required on_delete parameter.
• Currently, we are using version 1.1.0 of django-filters, it needs to be updated to 2.0.0.
• This line Remove deprecated code #5341

  url(r'^admin/', include(admin.site.urls))

  needs to be changed to this:

  url(r'^admin/', admin.site.urls)

• Resolve these two clashes:

  builds.Version: (auth.E005) The permission codenamed 'view_version' clashes with a builtin permission for model 'builds.Version'.
  

  projects.Project: (auth.E005) The permission codenamed 'view_project' clashes with a builtin permission for model 'projects.Project'.
  

[agjohnson]

We'll need to ease into this one. We have a separate code base for our commercial hosting to consider as well.

Thanks for compiling the information @dojutsu-user, that's really helpful.

I'm going to target this a few versions out, it's not a huge priority seeming we are still getting over just upgrading to the current LTS.

[humitos]

Django 2.2 is already released. This issue is not blocked anymore. It would be good to receive contributions for this migration.

We have a separate code base for our commercial hosting to consider as well.

I suppose the changes there won't be too many considering the list of deprecated things.

[davidfischer]

I suppose the changes there won't be too many considering the list of deprecated things.

Well, there will be a fair bit of changes and coordinating with the other repos will involve some challenges. For example, every single urls.py file will require changes. Every single models.py with a foreign key will require changes.

[stsewd]

We also need to check if our dependencies support django 2.x

[dojutsu-user]

It would be good to receive contributions for this migration.

Will definitely send PRs relating to this.

[davidfischer]

Django 2.x added SESSION_COOKIE_SAMESITE and CSRF_COOKIE_SAMESITE. I believe no changes to our codeline are required as the default values are appropriate for us.