Skip to content

Remove deprecated build URLs #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Jan 2, 2019 · 4 comments · Fixed by #5479
Closed

Remove deprecated build URLs #5057

humitos opened this issue Jan 2, 2019 · 4 comments · Fixed by #5479
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
3.5

Comments

@humitos
Copy link
Member

humitos commented Jan 2, 2019

Once #4568 gets merged, deployed and after 31st January we can remove all of these URLs and all the code associated to them since they will stop working and won't be used anymore.

Similar PR for corporate site at https://github.com/rtfd/readthedocs-corporate/pull/433
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jan 2, 2019
@humitos humitos added this to the 3.0 milestone Jan 2, 2019
@agjohnson
Copy link
Contributor

Note: After Jan 31st, we can remove the github endpoint, after Apr 1st, we can remove the rest or at least throw an exception from them.

@agjohnson agjohnson modified the milestones: 3.0, 3.2, 3.4 Jan 25, 2019
@stsewd stsewd modified the milestones: 3.4, 3.5 Mar 27, 2019
@dojutsu-user
Copy link
Member

dojutsu-user commented Apr 5, 2019 •
edited
Loading

I am interested in sending a PR for this.
But, I am not able to find what exactly needs to be removed.
Can I get some help on this to get started with this issue.

Edit: I think I get this. Will make a PR soon.

@stsewd
Copy link
Member

stsewd commented Apr 5, 2019

@dojutsu-user there is a PR open for this #5479

@humitos humitos mentioned this issue Apr 5, 2019
Merged
@dojutsu-user
Copy link
Member

@stsewd
Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Remove old/deprecated build endpoints readthedocs/readthedocs.org
4 participants
@humitos @agjohnson @stsewd @dojutsu-user