Skip to content

Enable no shallow clone flag for 'patchwork' #5044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephenfin opened this issue Dec 28, 2018 · 4 comments
Closed

Enable no shallow clone flag for 'patchwork' #5044

stephenfin opened this issue Dec 28, 2018 · 4 comments
Labels
Support Support question

Comments

@stephenfin
Copy link
Contributor

As noted in #5031 (comment), the use of shallow clones breaks patchwork.readthedocs.io. While git-pw (and presumably infrared) are now functioning as expected, patchwork is still broken. Could someone check that the flag is definitely enabled for this project now?

@humitos
Copy link
Member

humitos commented Dec 28, 2018

patchwork has already enabled the feature flag.

If you take a look at the output from https://readthedocs.org/projects/patchwork/builds/8328012/ you will notice that there is no --depth 50 argument.

It's probably failing for a different reason.

Also, I just triggered a new build and it passes: https://readthedocs.org/projects/patchwork/builds/8329977/

@humitos humitos added the Support Support question label Dec 28, 2018
@stephenfin
Copy link
Contributor Author

Weird. I tried on another branch and the first build failed but the second passed. I wonder if the failed build is cleaning something up?

@avishaymahluf
Copy link

Weird. I tried on another branch and the first build failed but the second passed. I wonder if the failed build is cleaning something up?

It also failed for me on Infrared on the first attempt, after I wiped the latest and retriggered the build it passed.
It seems that only after the wipe it cloned the whole repo instead of doing "git remote set-url" and "git fetch".

@stsewd
Copy link
Member

stsewd commented Jan 2, 2019

Weird. I tried on another branch and the first build failed but the second passed. I wonder if the failed build is cleaning something up?

Yes, you need to wipe the version before building it (admin -> versions -> edit -> wipe), that way git can clone the whole repo.

@stsewd stsewd closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

4 participants