Skip to content

Make raw_config private #4966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Dec 6, 2018 · 8 comments · Fixed by #6199
Closed

Make raw_config private #4966

stsewd opened this issue Dec 6, 2018 · 8 comments · Fixed by #6199
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Milestone

Comments

@stsewd
Copy link
Member

stsewd commented Dec 6, 2018

In the config module we shouldn't mutate the original value, this is solved, but we are still exposing the raw_config as a public attribute, but we are mutating that attribute internally, we should make that private. And maybe expose the original too? We don't use that anywhere, so not sure.

Raised in #4740 (comment)
Blocked by #4740

@stsewd stsewd added Improvement Minor improvement to code Status: blocked Issue is blocked on another issue labels Dec 6, 2018
@stsewd stsewd self-assigned this Dec 6, 2018
@dojutsu-user
Copy link
Member

@stsewd
I think that this issue is no longer blocked.

we should make that private

By this... did you mean to change the variable name to _raw_config?

@stsewd stsewd removed the Status: blocked Issue is blocked on another issue label Apr 16, 2019
@stsewd stsewd added this to the Refactoring milestone Apr 16, 2019
@stsewd
Copy link
Member Author

stsewd commented Apr 16, 2019

Yeah, maybe rename it to something more explicit if it makes sense or keep the same name, that's fine

@dojutsu-user
Copy link
Member

I suggest to rename it to raw_config_copy.

@stsewd
Copy link
Member Author

stsewd commented Apr 16, 2019

If renamed it should still be private, I don't see _copy adding more meaning, we can just keep the same name I guess

@dojutsu-user
Copy link
Member

Okay... then, I think it can be renamed to _raw_config or else this issue can be closed.

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 31, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap Good First Issue Good for new contributors and removed Status: stale Issue will be considered inactive soon labels May 31, 2019
@stsewd stsewd removed their assignment Aug 19, 2019
@kushthedude
Copy link

@stsewd As far as I can understand, We need to make raw_config private and show a raw-config example file ?

@stsewd
Copy link
Member Author

stsewd commented Aug 26, 2019

Just make it private for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants