-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Make raw_config private #4966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@stsewd
By this... did you mean to change the variable name to |
Yeah, maybe rename it to something more explicit if it makes sense or keep the same name, that's fine |
I suggest to rename it to |
If renamed it should still be private, I don't see |
Okay... then, I think it can be renamed to |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@stsewd As far as I can understand, We need to make |
Just make it private for now. |
In the config module we shouldn't mutate the original value, this is solved, but we are still exposing the
raw_config
as a public attribute, but we are mutating that attribute internally, we should make that private. And maybe expose the original too? We don't use that anywhere, so not sure.Raised in #4740 (comment)
Blocked by #4740
The text was updated successfully, but these errors were encountered: