Skip to content

python 3.7 compatibility problem #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Seburath opened this issue Oct 13, 2018 · 9 comments
Closed

python 3.7 compatibility problem #4756

Seburath opened this issue Oct 13, 2018 · 9 comments
Assignees
Labels
Improvement Minor improvement to code Needed: patch A pull request is required Status: blocked Issue is blocked on another issue
Milestone

Comments

@Seburath
Copy link

Seburath commented Oct 13, 2018

Details

This is the Fisrt Issue I publish, sorry If It have mistakes

Im trying to run my the readthedocs site on my machine, but I get an error.
On:

python manage.py migrate

Expected Result

Server running...

Actual Result

SyntaxError: Generator expression must be parenthesized
@Seburath
Copy link
Author

Seburath commented Oct 13, 2018

@stsewd make me understand that this is not urgent, so I will be working here :)

@stsewd
Copy link
Member

stsewd commented Oct 13, 2018

Just to be clear, this error only happens when running rtd with python 3.7, it works fine with <=3.6.

@humitos humitos added Improvement Minor improvement to code Needed: patch A pull request is required labels Oct 15, 2018
@humitos humitos added this to the Refactoring milestone Oct 15, 2018
@aanm
Copy link

aanm commented Oct 31, 2018

I'm hitting the same issue.

  File "/home/aanm/rtd/lib/python3.7/site-packages/django/contrib/admin/widgets.py", line 152
    '%s=%s' % (k, v) for k, v in params.items(),
    ^
SyntaxError: Generator expression must be parenthesized

@dojutsu-user
Copy link
Member

dojutsu-user commented Nov 2, 2018

@aanm
The reason for this error is that Django 1.11 is not compatible with Python3.7 and probably there are no plans to make Django 1.11 compatible with latest version of python. (see the discussion here)
Please stick to Python<=3.6

@stsewd
Copy link
Member

stsewd commented Jan 2, 2019

Python3.7 support was added to django 1.11.17 (released the past december) https://docs.djangoproject.com/en/2.1/releases/1.11.17/. I'll update the version soon.

@stsewd stsewd self-assigned this Jan 2, 2019
@davidfischer
Copy link
Contributor

I believe Celery is also not yet compatible with 3.7.

@stsewd
Copy link
Member

stsewd commented Jan 2, 2019

Yeah, celery/celery#4913 (comment), and we are blocked in the celery update #4643

@humitos
Copy link
Member

humitos commented Jan 25, 2020

I believe this is not an issue anymore since we upgraded celery finally. On the other hand, we are now mentioning that 3.6 is the Python version to use: https://docs.readthedocs.io/en/stable/development/install.html#requirements

I'm closing it for now since we don't plan to officially support > 3.6 for now.

@humitos humitos closed this as completed Jan 25, 2020
@sivaraam
Copy link

I believe this is not an issue anymore since we upgraded celery finally. On the other hand, we are now mentioning that 3.6 is the Python version to use: docs.readthedocs.io/en/stable/development/install.html#requirements

While that was nice, it's sad that the documentation didn't help me realize quickly that RTF does not run with Python 3.7 (which to be honest, is very strange given that 3.7 is needed for building the docs locally!). I had to search through a related issues to find this weirdness. The fact that the hyperlink for the "Python 3.6" text in the documentation just links to the Python website homepage didn't help me either.

Given that distributions have started shipping Python version > 3.6 by default (Python 3.8.2 in Ubuntu 20.04 at the time of writing), it would be great if the documentation is updated to mention that RTD doesn't support Python version > 3.6 yet for running as a least measure. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: patch A pull request is required Status: blocked Issue is blocked on another issue
Projects
None yet
Development

No branches or pull requests

7 participants