latest is reactivated on commit

[davidism]

I've disabled the "latest" version. However, every time I push a commit to master, the version is reactivated on RTD. I'd like for the version to stay disabled even on new commits.

[stsewd]

I was able to replicate this on the .org site

[stsewd]

I guess this only happens via webhooks, as master is latest, then rtd builds that branch and activates latest.

[stsewd]

The code that is changing the active attr is

https://github.com/rtfd/readthedocs.org/blob/35695d170ec7e1dfa2553bf70bc406e7c960409a/readthedocs/core/views/hooks.py#L40-L45

(here slug is master, but it triggers a build to latest)

I'll continue investigating why we are triggering a build to latest there, it may be a bug or some weird design.

[stsewd]

I think I understand why we are doing that, we should validate that the version is active first