Skip to content

Celery update breaks our code #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Sep 17, 2018 · 5 comments
Closed

Celery update breaks our code #4640

stsewd opened this issue Sep 17, 2018 · 5 comments
Labels
Bug A bug

Comments

@stsewd
Copy link
Member

stsewd commented Sep 17, 2018

Today I reinstalled my virtual env, reinstalling the requirements noted this when building a simple project:

     raise RuntimeError(E_WOULDBLOCK)
RuntimeError: Never call result.get() within a task!
See http://docs.celeryq.org/en/latest/userguide/tasks.html#task-synchronous-subtasks

This is because of this change celery/celery#4432, we need to:

  1. downgrade celery
  2. refactor our code

I'm trying 2 now

@stsewd stsewd added the Bug A bug label Sep 17, 2018
@stsewd
Copy link
Member Author

stsewd commented Sep 18, 2018

Ok, this only happens in development (CELERY_ALWAYS_EAGER = True). I'm not sure how to fix this, we need a way to pass disable_sync_subtasks=False down to the get method, but I found that options isn't used there...

https://github.com/celery/celery/blob/a1fb557b6ecc494514e3480518be57b985d0927d/celery/canvas.py#L1240

So, if there isn't another way of passing the disable_sync option, we can:

  • Require to run rtd on dev with celery on
  • Downgrade celery
  • Maybe send a patch to celery project?

@agjohnson
Copy link
Contributor

FWIW, I never use ALWAYS_EAGER in development. I used contrib/supervisord.conf to start all the services

@stsewd
Copy link
Member Author

stsewd commented Sep 18, 2018

I use supervisor sometimes, but it gets too heavy sometimes for my computer p:

So, should we update our installation guide?

@stsewd
Copy link
Member Author

stsewd commented Sep 18, 2018

We already mention the redis installation there

This was referenced Sep 18, 2018
@humitos
Copy link
Member

humitos commented Oct 1, 2018

FWIW, I never use ALWAYS_EAGER in development. I used contrib/supervisord.conf to start all the services

Tests run with ALWAYS_EAGER, so I think we need to have this working also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

3 participants