Skip to content

Question about subprojects #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vivianyangsh opened this issue Sep 10, 2018 · 8 comments
Closed

Question about subprojects #4623

vivianyangsh opened this issue Sep 10, 2018 · 8 comments

Comments

@vivianyangsh
Copy link

vivianyangsh commented Sep 10, 2018

Details

By following https://docs.readthedocs.io/en/latest/subprojects.html, we configured project b,c,d as the subproject of a, expecting that these projects will share search index.

We hosted the docs in our own server, so not a project on readthedocs.

Expected Result

When I search in project a, search engine should search among a and its subprojects.

Actual Result

When I search in project a with a keyword that appears in b, no result is returned.

Question

Is this working as designed? How to achieve my expected result?

@stsewd stsewd added Feature New feature Needed: design decision A core team decision is required labels Sep 10, 2018
@stsewd
Copy link
Member

stsewd commented Sep 10, 2018

I'm not sure if that's by design, but if not, looks like a feature request.

@vivianyangsh
Copy link
Author

@stsewd Thanks so much!

In the documentation, it is said Projects that are configured as subprojects will share a search index with their parent and sibling projects. This is currently the only way to share search indexes between projects, we do not yet support sharing search indexes between arbitrary projects.

So that I am figuring that the expected behavior should be what's designed. Can you please help confirm. If not, then, yes, this is definitely a new feature needed;-) For big documentation projects that spread among several repos, we need the search to happen in all repos.

@stsewd
Copy link
Member

stsewd commented Sep 12, 2018

oh, I didn't read that. I think that should work, I'll investigate a little more.

@agjohnson
Copy link
Contributor

This is a feature already built into RTD search. You need elastic search setup and the correct indexes. Unless there is a more specific problem with search indexing, I don't think there is much we can act on here. Perhaps stack overflow is better place for a support question like this?

Closing for now. If you have a bug report, feel free to reopen.

@agjohnson agjohnson removed Feature New feature Needed: design decision A core team decision is required labels Sep 13, 2018
@stsewd
Copy link
Member

stsewd commented Sep 13, 2018

@agjohnson
Copy link
Contributor

I'm seeing bad search results even just searching those projects for terms that should be locally indexed, so this probably is a problem with indexing in general, not a problem with this indexing feature.

For example, I get results that back down to Sphinx results here:
https://rtd-test-stsewd.readthedocs.io/projects/stsewd-demo/en/latest/search.html?q=Eric&check_keywords=yes&area=default

This term exists in the local document, I'd expect this in our results

@stsewd
Copy link
Member

stsewd commented Sep 14, 2018

Just commenting that we solve this rebuilding the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants