Skip to content

Use ignore keyword to ignore the requirements file #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Aug 15, 2018 · 2 comments
Closed

Use ignore keyword to ignore the requirements file #4523

stsewd opened this issue Aug 15, 2018 · 2 comments
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Aug 15, 2018

Currently, we use '' empty string to rtd ignore completely a requirements file, we can't use null, as that behavior is for automatically find a requirements file.

We have a suggestion to use a ignore keyword for this, as we use the all keyword for formats

Ref to #4451 (comment)
@stsewd stsewd added the Needed: design decision A core team decision is required label Aug 15, 2018
This was referenced Aug 15, 2018
Merged
Merged
@stsewd
Copy link
Member Author

stsewd commented Aug 15, 2018

Also, self.config.python.requirements could return IGNORE when the YAML contains '' (in case we won't change that for the explicit way).

from #4456 (comment)

@stsewd
Copy link
Member Author

stsewd commented Oct 22, 2018

We don't need this anymore #4732 (comment)

@stsewd stsewd closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stsewd