Skip to content

Support strict validation for the configuration file #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stsewd opened this issue Jul 31, 2018 · 2 comments
Closed

Support strict validation for the configuration file #4455

stsewd opened this issue Jul 31, 2018 · 2 comments
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Jul 31, 2018

We can support strict validation in the configuration file (v2 only at this point).

What do I mean by strict validation?

Just to validate that there aren't other keys in the config file

Why do we want this?

It can prevent typos :). It should be straightforward to implement this in the current validation steps. Just pop each value whenever it is used.

@stsewd stsewd added the Needed: design decision A core team decision is required label Jul 31, 2018
@davidfischer
Copy link
Contributor

I'm +1 for this as it will prevent future bugs.

@agjohnson agjohnson added this to the YAML File Completion milestone Aug 2, 2018
@humitos
Copy link
Member

humitos commented Sep 5, 2018

I think this is something good to have. I will avoid confusions to users, and by given them a good validation error message, it's something that they can fix by themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

4 participants